add tls/security details of connection/request (TLS protocol, cipher)…

… to mitmweb (mitmproxy#4117)
snemes · Jul 30, 2020 · 2f33d6c · 2f33d6c
1 parent b1e1b1f
commit 2f33d6c
Show file tree

Hide file tree

Showing 3 changed files with 83 additions and 1 deletion.
diff --git a/mitmproxy/tools/web/static/app.js b/mitmproxy/tools/web/static/app.js
diff --git a/web/src/js/__tests__/components/FlowView/__snapshots__/DetailsSpec.js.snap b/web/src/js/__tests__/components/FlowView/__snapshots__/DetailsSpec.js.snap
@@ -27,6 +27,34 @@ exports[`ConnectionInfo Component should render correctly 1`] = `
         address
       </td>
     </tr>
+    <tr>
+      <td>
+        TLS version:
+      </td>
+      <td>
+        TLSv1.2
+      </td>
+    </tr>
+    <tr>
+      <td>
+        cipher name:
+      </td>
+      <td>
+        cipher
+      </td>
+    </tr>
+    <tr>
+      <td>
+        <abbr
+          title="ALPN protocol negotiated"
+        >
+          ALPN:
+        </abbr>
+      </td>
+      <td>
+        http/1.1
+      </td>
+    </tr>
   </tbody>
 </table>
 `;
@@ -62,6 +90,34 @@ exports[`Details Component should render correctly 1`] = `
           address
         </td>
       </tr>
+      <tr>
+        <td>
+          TLS version:
+        </td>
+        <td>
+          TLSv1.2
+        </td>
+      </tr>
+      <tr>
+        <td>
+          cipher name:
+        </td>
+        <td>
+          cipher
+        </td>
+      </tr>
+      <tr>
+        <td>
+          <abbr
+            title="ALPN protocol negotiated"
+          >
+            ALPN:
+          </abbr>
+        </td>
+        <td>
+          http/1.1
+        </td>
+      </tr>
     </tbody>
   </table>
   <h4>
@@ -91,6 +147,14 @@ exports[`Details Component should render correctly 1`] = `
           address
         </td>
       </tr>
+      <tr>
+        <td>
+          TLS version:
+        </td>
+        <td>
+          TLSv1.2
+        </td>
+      </tr>
     </tbody>
   </table>
   <div />

diff --git a/web/src/js/components/FlowView/Details.jsx b/web/src/js/components/FlowView/Details.jsx
@@ -34,6 +34,24 @@ export function ConnectionInfo({ conn }) {
                         <td>{conn.sni}</td>
                     </tr>
                 )}
+                {conn.tls_version && (
+                    <tr key="tls_version">
+                        <td>TLS version:</td>
+                        <td>{conn.tls_version}</td>
+                    </tr>
+                )}
+                {conn.cipher_name && (
+                    <tr key="cipher_name">
+                        <td>cipher name:</td>
+                        <td>{conn.cipher_name}</td>
+                    </tr>
+                )}
+                {conn.alpn_proto_negotiated && (
+                    <tr key="ALPN">
+                        <td><abbr title="ALPN protocol negotiated">ALPN:</abbr></td>
+                        <td>{conn.alpn_proto_negotiated}</td>
+                    </tr>
+                )}
             </tbody>
         </table>
     )