Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E3DC nun komplett auf openwb V2.0 Struktur umgestellt #2449
E3DC nun komplett auf openwb V2.0 Struktur umgestellt #2449
Changes from all commits
7858789
acf50f4
7d2fdbb
b7e27f1
4fec76f
ddbe6aa
502a9d7
6809da8
6a38f02
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"max 6 Leistungsmesser verbaut": Das ist immernoch der alte Kommentar. Der Code liest bis zu 7 Leistungsmesser aus. Entweder der Kommentar lügt oder der Code weiter unten liest unnötigerweise 28 Register aus und die 28 sollte durch eine 24 getauscht werden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diese Zeile vom Kommentar scheint mir keine Hilfe zu sein.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Du hattest dich nicht zu meinem Einwand geäußert, dass
_address
nur zwecks Logausgabe mitgeschleppt wird. Eine Mögliche Alternative wäre in der Funktionupdate_components
in derdevice.py
eine Logausgabe "reading %s" mit der Adresse rauszuhauen. Dann ist die IP auch geloggt, aber du musst die nicht überall durchschleppen.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Du hattest dich nicht zu meinem Einwand geäußert, dass
_address
nur zwecks Logausgabe mitgeschleppt wird. Eine Mögliche Alternative wäre in der Funktionupdate_components
in derdevice.py
eine Logausgabe "reading %s" mit der Adresse rauszuhauen. Dann ist die IP auch geloggt, aber du musst die nicht überall durchschleppen.