Introduce internal components #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
changed the title
pscott
changed the title
pscott
force-pushed
the
use_internal_components
branch
from
df42704
to
31ce28c
Compare
pscott
force-pushed
the
use_internal_components
branch
from
31ce28c
to
636ca52
Compare
pscott
force-pushed
the
use_internal_components
branch
from
c233507
to
fff5cde
Compare
|
missing: use prefix for storage variables of components to avoid namespace clashing |
done |
pscott
force-pushed
the
use_internal_components
branch
from
8d000ed
to
7b21f43
Compare
pscott
force-pushed
the
use_internal_components
branch
from
eaf8570
to
86e78d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/snapshot-labs/workflow/issues/162
In this PR we remove all the
unsafe_new_contract_state()by making use of cairo components.This is mostly just syntax modifications, but it does indeed touch to the precious
.cairofiles.To make it easy to review, every component was introduced in a different commit.