feat: simple majority execution #534
Conversation
starknet/src/execution_strategies/no_execution_simple_majority.cairo
Outdated
Show resolved
Hide resolved
| ProposalStatus::VotingDelay(()) | ||
| } else if timestamp < *proposal.min_end_timestamp { | ||
| ProposalStatus::VotingPeriod(()) | ||
| } else if timestamp < *proposal.max_end_timestamp { |
There was a problem hiding this comment.
we shouldnt have a VotingPeriodAccepted status with the strategy
There was a problem hiding this comment.
i think just ignore min_end_timestamp
There was a problem hiding this comment.
Hmm so the rationale behind that was:
- those who don't want the early end can set min/max to the same value
- those who want to have an early end (for whatever reason) can still have it without having to write another strategy
There was a problem hiding this comment.
the thing is min/max are space params they cant be set just for proposals with this strategy.
The goal of a 'simple majority' strategy is to find the majority of VP over the voting period. i dont think it would ever make sense to have an early end. So if spaces are using this execution strategy in combination with others, they would need to update space params often which would be annoying/ error prone.
There was a problem hiding this comment.
fair enough ! f6ac7e0
starknet/src/execution_strategies/no_execution_simple_majority.cairo
Outdated
Show resolved
Hide resolved
Closes #531