feat: prevent zero address for author/voter #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
requested changes
Aug 17, 2023
|
|
||
| // Create Proposal | ||
| authenticator.authenticate(space.contract_address, PROPOSE_SELECTOR, propose_calldata); | ||
| } |
There was a problem hiding this comment.
Erm I know you wrote a lot of the code but I would suggest to do these tests:
write a test module that only does a unit test on is_zero (could actually be inside of user_address.cairo tbh but doesn't have to).
In this unit test we try starknet, ethereum, and custom).
And then we actually test the three entrypoints (to get full code coverage and regression test), on cancel, propose, update_proposal, and vote. This time we don't care about whether they're starknet or ethereum, we just check to see if the code is here :)
There was a problem hiding this comment.
yep got the unit tests and all entry points tested. sorry was being a bit lazy
pscott
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #488