feat: stark tx auth #477
feat: stark tx auth #477
Conversation
| let (factory, space) = deploy(@config); | ||
| let authenticator = setup_stark_tx_auth(space, config.owner); | ||
|
|
||
| let quorum = u256_from_felt252(1); |
There was a problem hiding this comment.
actually can grep and replace u256_from_felt252(constant)
There was a problem hiding this comment.
oh theres a lot of other places where i used u256_from_felt252 or even u256 { 1, 0} so will fix on a diff pr
| let authenticator = setup_stark_tx_auth(space, config.owner); | ||
|
|
||
| let quorum = u256_from_felt252(1); | ||
| let mut constructor_calldata = ArrayTrait::<felt252>::new(); |
There was a problem hiding this comment.
can we use let mut constructor_calldata: Array<felt252> = array![] here?
There was a problem hiding this comment.
im not sure how to do this while serializing the types into the array of felts. any ideas?
There was a problem hiding this comment.
I don't think you can do this in a one liner but here I was just referring to using array![] instead of ArrayTrait::<felt252>::new()
There was a problem hiding this comment.
serializing will still need to be done on the line just after i'm afraid
| ArrayTrait::<felt252>::new(), | ||
| ArrayTrait::<felt252>::new() | ||
| ); |
No description provided.