feat: whitelist proposal validation #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hard to see the actual diff cuz of changing paths. I just need to review |
Orland0x
reviewed
Aug 16, 2023
| let mut user_params = ArrayTrait::<felt252>::new(); | ||
| let fake_leaf = Leaf { | ||
| address: UserAddress::Starknet(contract_address_const::<0x1337>()), | ||
| voting_power: leaf.voting_power + 1, |
There was a problem hiding this comment.
looks like the voting power and address are both modified
Orland0x
reviewed
Aug 16, 2023
| struct Storage {} | ||
|
|
||
| #[derive(Drop, Serde)] | ||
| struct Input { |
There was a problem hiding this comment.
could call something like StrategyParams, which we could use in all strategies to define the deserialization of params so its clear what this refers to.
Orland0x
reviewed
Aug 16, 2023
| use starknet::contract_address_const; | ||
| use sx::types::UserAddress; | ||
|
|
||
| // Checks that that the leaf at the given index is correclty accepted or rejected (given a certain `threshold`). |
Orland0x
reviewed
Aug 16, 2023
| let members = generate_n_members(20); | ||
| let threshold = 3_u256; // Voting power required to submit a proposal | ||
|
|
||
| let (contract, _) = deploy_syscall( |
There was a problem hiding this comment.
could put following 10 lines into a setup() utility as its duplicated in every test
|
closed in favor of #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the merkle implementation of the voting strategy.
Closes #473