audit: L-02 No Gap Variable (#591)

* fix: use gaps in SimpleQuorumExecutionStrategy and StarnketSpaceManager --------- Co-authored-by: Orland0x <[email protected]>
snapshot-labs · Oct 10, 2023 · cc1ef75 · cc1ef75
1 parent 06ec6f5
commit cc1ef75
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/ethereum/src/execution-strategies/SimpleQuorumExecutionStrategy.sol b/ethereum/src/execution-strategies/SimpleQuorumExecutionStrategy.sol
@@ -76,4 +76,9 @@ abstract contract SimpleQuorumExecutionStrategy is IExecutionStrategy, StarknetS
     }
 
     function getStrategyType() external view virtual override returns (string memory);
+
+    /// @dev This empty reserved space is put in place to allow future versions to add new
+    ///      variables without shifting down storage in the inheritance chain.
+    ///      See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps
+    uint256[49] private __gap;
 }
diff --git a/ethereum/src/execution-strategies/StarknetSpaceManager.sol b/ethereum/src/execution-strategies/StarknetSpaceManager.sol
@@ -57,4 +57,9 @@ contract StarknetSpaceManager is OwnableUpgradeable {
         if (spaces[space] == FALSE) revert InvalidSpace();
         _;
     }
+
+    /// @dev This empty reserved space is put in place to allow future versions to add new
+    ///      variables without shifting down storage in the inheritance chain.
+    ///      See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps
+    uint256[49] private __gap;
 }