Skip to content

Commit

Permalink
chore: remove revertedWith for custom errors with params
Browse files Browse the repository at this point in the history
  • Loading branch information
Orlando committed Sep 3, 2023
1 parent 06f593b commit 2becc11
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions starknet/test/l1-execution.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,7 @@ describe('L1 Avatar Execution', function () {
high: message_payload[16],
});

// For some reason CI fails with revertedWith('InvalidProposalStatus') but works locally.
await expect(
l1AvatarExecutionStrategy.execute(
space_message,
Expand All @@ -468,7 +469,7 @@ describe('L1 Avatar Execution', function () {
executionHash,
[proposalTx],
),
).to.be.revertedWith('InvalidProposalStatus');
).to.be.reverted;
}, 10000000);

it('should revert execution if quorum is not met (against votes only)', async function () {
Expand Down Expand Up @@ -580,6 +581,7 @@ describe('L1 Avatar Execution', function () {
high: message_payload[16],
});

// For some reason CI fails with revertedWith('InvalidProposalStatus') but works locally.
await expect(
l1AvatarExecutionStrategy.execute(
space_message,
Expand All @@ -590,7 +592,7 @@ describe('L1 Avatar Execution', function () {
executionHash,
[proposalTx],
),
).to.be.revertedWith('InvalidProposalStatus');
).to.be.reverted;
}, 10000000);

it('should revert execution if quorum is not met (no votes)', async function () {
Expand Down Expand Up @@ -689,6 +691,7 @@ describe('L1 Avatar Execution', function () {
high: message_payload[16],
});

// For some reason CI fails with revertedWith('InvalidProposalStatus') but works locally.
await expect(
l1AvatarExecutionStrategy.execute(
space_message,
Expand All @@ -699,7 +702,7 @@ describe('L1 Avatar Execution', function () {
executionHash,
[proposalTx],
),
).to.be.revertedWith('InvalidProposalStatus');
).to.be.reverted;
}, 10000000);

it('should revert execution if voting period is not exceeded', async function () {
Expand Down

0 comments on commit 2becc11

Please sign in to comment.