Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update starknetkit to v2 #849

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

fix: update starknetkit to v2 #849

wants to merge 4 commits into from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 7, 2024

Summary

Toward #478

Update starknetkit to v2, to take advantage of the new silent_mode when connecting to wallet, which will allow user to silently connect to their argent x wallet only if unlocked.

This PR just update the dependency, and the connector code to make use of their new connection method, silent connection will come in a later PR

How to test

  1. Connect with your argent X connectors (argentx, braavos, argent x movile)
  2. It should work
  3. Sign/Send some transaction
  4. It should work

NOTE

  • It seems that v2 is having some issues with Braavos. Connecting with braavos, then logging out, then logging in again is throwing an 'User rejected request' error. Need more debugging and reproduction to detect if issue is coming from the lib, in which case, will create an issue on the lib repo

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 60c5359

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Oct 10, 2024

Getting an error on the braavos connector, confirmed to be an issue from starknetkit, waiting for a fix, see argentlabs/starknetkit#140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant