fix: don't show empty placeholder account in the account button

[wa0x6e]

Summary

This fix an issue when metamask is locked, and logged out user is not accepting to unlock it when prompted

Issue reproduction

• Logged out of all metamask account
• Lock metamask
• Click on the "Connect wallet" button in the top right corner
• It should prompt you to unlock metamask
• Ignore it and go back to the site
• The "Connect wallet" button should still be stuck in the loading state
• Refresh the page
• The account button should be back to "Connect wallet" state
• Click on it, and choose metamask again
• The button will show:

• Even after refreshing the page, the button will still continue to show that state

This PR will try to fix this issue by showing a special state for when metamask is waiting for an user action, by showing the "Waiting for your wallet" message (can be improved)

How to test

1. Use the same steps as the reproduction steps above
2. Instead of the 0x000 icon and empty account name, it should show the "Waiting for your wallet" message

Note

• This fix is specific to metamask, as in the case of argent x and braavos, refusing to unlock by closing the argentX/Braavos popup will revert to unlogged state.
• This will not fix the issue in bug: connector is triggered on page load #478, which is another issue specific to logged in user

[wa0x6e]

btw, We don't handle this case on snapshot.org, the connect button just crash, and don't appear anymore

[ChaituVR]

tAck

[Sekhmet]

Do we need another loading state? We already have one loading state (just loading indicator), now we are adding another different state which to me means the same.

Is it related to this PR? #220

I feel like situation where isAuthenticated is true but account is missing is indicator that something else is broken, we should prevent this situation as it might cause issues in other parts of the app.

[wa0x6e]

Do we need another loading state? We already have one loading state (just loading indicator), now we are adding another different state which to me means the same.

Is it related to this PR? #220

I feel like situation where isAuthenticated is true but account is missing is indicator that something else is broken, we should prevent this situation as it might cause issues in other parts of the app.

This is continuation of fixing of #220 indeed.

In the previous PR, we fixed the error occuring after the page refresh step.
This PR take things a step further, it fixes the error occuring when clicking on the "Connect wallet" button, after page refresh.

This PR is quickfix, the best way to fix this would be trigger the metamask prompt again when you want to connect to metamask.

Seems it's an open issue for years MetaMask/metamask-extension#10085

There's some kind of solution proposed there, will try a few

[wa0x6e]

Will instead be fixed in amount, with snapshot-labs/lock#114

This will fix the issue where an authenticated user is not authenticated

[wa0x6e]

This issue has been resolved with new version of lock: snapshot-labs/lock@b5a3203

@Sekhmet how are packages updated ?

[Sekhmet]

@wa0x6e it looks like 0.2.5 was published via CI after your PR was merged. So here you just bump package to the version you need and run yarn in repo root.