Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix gap in proposal sidebar bottom #1003

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Nov 28, 2024

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/297

This PR fix the gap in the Affix sidebar bottom.

Most of the changes are about adding an encapsulating <div> to all views which do not already have it, to allow passing the pb-6 class to router view, instead of it being set directly on the Layout/App.

This will allow each view to overwrite the bottom padding class if necessary, instead of polluting the App layout.

How to test

  1. Go to http://localhost:8080/#/s:aave.eth/proposal/0xef7dfa4e96e5f6a7337648d2dd3882f7b10e969c9564c118a34ce99eccec9383
  2. Scroll to bottom of the page
  3. The right sidebar bottom should go all the way to the page bottom

@wa0x6e wa0x6e requested a review from ChaituVR November 28, 2024 06:12
@wa0x6e wa0x6e marked this pull request as ready for review November 28, 2024 14:26
apps/ui/src/views/Proposal.vue Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from ChaituVR November 29, 2024 08:59
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Nov 29, 2024

Description updated to explain why there's so many files changed

@ChaituVR
Copy link
Member

Haven't reviewed/tested everything but i noticed this border missing when votes are loading
image

@ChaituVR
Copy link
Member

ChaituVR commented Nov 30, 2024

Untitled 4

This pb-6 is missing on proposal page with new changes, at first I thought this space is useless but when I open mobile menu, some part of proposal is not visible

Current UI New changes
image image

maybe we need this space?

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Dec 1, 2024

Untitled 4 This pb-6 is missing on proposal page with new changes, at first I thought this space is useless but when I open mobile menu, some part of proposal is not visible

Current UI New changes
image image
maybe we need this space?

the pb-6 class was not for the mobile bottom menu, as it was there before it was introduced. I think it's just there to give more room to main content, and avoid having it too close to page bottom.

Even on master, content is hidden behind the mobile menu

Screenshot 2024-12-01 at 23 27 12

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Dec 2, 2024

Haven't reviewed/tested everything but i noticed this border missing when votes are loading image

Fixed, by removing the absolute class on the loading indicator.

I noticed that it's the only place with that absolute class, and I did not noticed any issues by removing it. Is there some edge case I am not aware of ?

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

apps/ui/src/views/Space/Settings.vue Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants