Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send empty labels with proposals #4906

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix: send empty labels with proposals #4906

merged 2 commits into from
Oct 7, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Oct 7, 2024

Summary

How to test

  1. Create a proposal on any space
  2. Before it was throwing an error

@ChaituVR ChaituVR requested a review from wa0x6e October 7, 2024 07:43
@ChaituVR
Copy link
Member Author

ChaituVR commented Oct 7, 2024

Also fixed issue with choices
image

wa0x6e
wa0x6e approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit b4166c3 into master Oct 7, 2024
6 checks passed
@ChaituVR ChaituVR deleted the fix-labels-in-proposals branch October 7, 2024 09:16
@wa0x6e
Copy link
Collaborator

wa0x6e commented Oct 7, 2024 •
edited
Loading

As said in our last call, this should use existing value when available, instead of always empty array, for the update proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

@bonustrack bonustrack Awaiting requested review from bonustrack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e