Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): fix overflowing text #4879

Merged
merged 5 commits into from
Sep 18, 2024
Merged

fix(ui): fix overflowing text #4879

merged 5 commits into from
Sep 18, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Sep 18, 2024 •
edited
Loading

Summary

This PR fixes a few UI issues where long text would overflow their container

  • Limit username max length on topnav account to prevent this

Screenshot 2024-09-18 at 13 34 05

  • Do not shrink copyAddress button to prevent multi line button

Screenshot 2024-09-18 at 13 37 07

  • Force words break on BaseBlock to prevent overflow content

Screenshot 2024-09-18 at 13 34 56

  • Truncate username in SpaceDelegate top prevent overflow

Screenshot 2024-09-18 at 13 34 31

@wa0x6e wa0x6e changed the title Fix-ui-overflowing-username fix: fix overflowing text Sep 18, 2024
@wa0x6e wa0x6e changed the title fix: fix overflowing text fix(ui): fix overflowing text Sep 18, 2024
@wa0x6e wa0x6e marked this pull request as ready for review September 18, 2024 04:45
ChaituVR
ChaituVR approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit 071f4aa into master Sep 18, 2024
3 of 5 checks passed
@wa0x6e wa0x6e deleted the fix-ui-overflowing-username branch September 18, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR