feat(proposal): add validation to start time #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
wa0x6e
reviewed
Jun 15, 2023
samuveth
reviewed
Jun 16, 2023
src/components/ModalSelectDate.vue
Outdated
| @@ -39,6 +40,17 @@ watch(open, () => { | |||
| time.value = `${h}:${m}`; | |||
| input.value = dateString; | |||
| }); | |||
|
|
|||
| watchEffect(() => { | |||
There was a problem hiding this comment.
Okay I see now, but when I enter a time in the past the input is no longer functioning
There was a problem hiding this comment.
There was a problem hiding this comment.
Instead of filling the input automatically with the current time, we should let the user enter time in that past and when he clicks "Select" we should show a warning and prevent "Select"
…y/restrict-proposal-start-time
ChaituVR
added a commit
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#334
Fixes #
Set starting date not greater than the current time. Restrict users to enter lower time than the current time
How to test
To-Do
Self-review checklist
Additional notes or considerations
(Include any other relevant information or context that may be helpful for the reviewer)