Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create date start and end #2631

Closed
wants to merge 6 commits into from
Closed

Fix create date start and end #2631

wants to merge 6 commits into from

Conversation

samuveth
Copy link
Contributor

@vercel
Copy link

vercel bot commented Jun 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
snapshot ✅ Ready (Inspect) Visit Preview Jun 18, 2022 at 3:17PM (UTC)

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
There is still a 1-sec difference 😅I think it is not possible to get the same time? maybe we should change snapshot.js to use the same timestamp on timestamp and start if we pass now in start?

or we should have some buffer time like 15 secs on hub

@samuveth
Copy link
Contributor Author

Hm yeah not sure what is the best solution here. @bonustrack any thoughts?

@bonustrack
Copy link
Member

If proposal author select "now" as start date the start date should be the same as the created date

@samuveth
Copy link
Contributor Author

samuveth commented Jun 17, 2022

There is no such thing as now. Now is just something we show to the user on the Ui when the start time is set to the current time. @ChaituVR we could either add a buffer on the hub or we could make the start date = timestamp when within 5 seconds range

@samuveth
Copy link
Contributor Author

Or we can just pass the timestamp in the message then this will not trigger
image

@samuveth
Copy link
Contributor Author

Also we would need to handle this on Personal Sign and EIP712, they both calculate the timestamp when signing.

@stale
Copy link

stale bot commented Oct 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that are old and soon to be closed label Oct 14, 2022
@bonustrack bonustrack removed pinned stale Issues that are old and soon to be closed labels Oct 14, 2022
@stale
Copy link

stale bot commented Dec 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that are old and soon to be closed label Dec 13, 2022
@stale stale bot closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right stale Issues that are old and soon to be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants