-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Balance of At Scaled as well as erc721 collateral held #1327
Open
publu
wants to merge
4
commits into
snapshot-labs:master
Choose a base branch
from
publu:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# ve-balance-of-at-scaled | ||
|
||
This strategy returns the voting power of the voters for a ve-like token by calling `balanceOfAt` on the contract and then scales the result by a provided scale factor. | ||
|
||
Here is an example of parameters: | ||
|
||
```json | ||
{ | ||
"address": "0x1bffabc6dfcafb4177046db6686e3f135e8bc732", | ||
"symbol": "aveQI", | ||
"decimals": 18, | ||
"scaleValue": 1 | ||
} | ||
``` | ||
|
||
The `scaleValue` parameter is used to scale the result of the `balanceOfAt` call. For example, if `scaleValue` is 1, the result is not scaled. If `scaleValue` is 0.01, the result is scaled down by a factor of 100. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
[ | ||
{ | ||
"name": "Example query", | ||
"strategy": { | ||
"name": "ve-balance-of-at-scaled", | ||
"params": { | ||
"address": "0x1bffabc6dfcafb4177046db6686e3f135e8bc732", | ||
"symbol": "aveQI", | ||
"decimals": 18, | ||
"scaleValue": 4 | ||
} | ||
}, | ||
"network": "1", | ||
"addresses": [ | ||
"0x55C1568eFD6D19Edec498330952fA7e582FEA20A", | ||
"0xc06320d9028F851c6cE46e43F04aFF0A426F446c", | ||
"0x044325aCCB1A131cD00B4Cef674E9a8d9b60ad72", | ||
"0x680963fe5e628c5486C3A282ca12Aa575820e446" | ||
], | ||
"snapshot": 18383737 | ||
} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import { BigNumberish } from '@ethersproject/bignumber'; | ||
import { formatUnits } from '@ethersproject/units'; | ||
import { Multicaller } from '../../utils'; | ||
|
||
export const author = 'publu'; | ||
export const version = '0.0.1'; | ||
|
||
const abi = [ | ||
'function balanceOfAt(address _user,uint256 _blockNumber) external view returns (uint256)' | ||
]; | ||
|
||
export async function strategy( | ||
space, | ||
network, | ||
provider, | ||
addresses, | ||
options, | ||
snapshot | ||
): Promise<Record<string, number>> { | ||
const blockTag = | ||
typeof snapshot === 'number' ? snapshot : await provider.getBlockNumber(); | ||
|
||
const multi = new Multicaller(network, provider, abi); | ||
addresses.forEach((address) => | ||
multi.call(address, options.address, 'balanceOfAt', [address, blockTag]) | ||
); | ||
const result: Record<string, BigNumberish> = await multi.execute(); | ||
|
||
return Object.fromEntries( | ||
Object.entries(result).map(([address, balance]) => [ | ||
address, | ||
parseFloat(formatUnits(balance, options.decimals)) * options.scaleValue | ||
]) | ||
); | ||
Comment on lines
+20
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could you math strategy for this @publu let me know if you have some trouble doing so :) |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"$ref": "#/definitions/Strategy", | ||
"definitions": { | ||
"Strategy": { | ||
"title": "Strategy", | ||
"type": "object", | ||
"properties": { | ||
"symbol": { | ||
"type": "string", | ||
"title": "Symbol", | ||
"examples": ["e.g. aveQI"], | ||
"maxLength": 16 | ||
}, | ||
"address": { | ||
"type": "string", | ||
"title": "Contract address", | ||
"examples": ["e.g. 0x1bffabc6dfcafb4177046db6686e3f135e8bc732"] | ||
}, | ||
"decimals": { | ||
"type": "number", | ||
"title": "Decimals", | ||
"examples": ["e.g. 18"] | ||
}, | ||
"scaleValue": { | ||
"type": "number", | ||
"title": "Scale Value", | ||
"examples": ["e.g. 4"] | ||
} | ||
}, | ||
"required": ["address", "decimals", "scaleValue"], | ||
"additionalProperties": false | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @publu One PR should contain changes of one strategy only.