Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing comma #2612

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add missing comma #2612

merged 1 commit into from
Jul 31, 2024

Conversation

ChaituVR
Copy link
Member

No description provided.

@ChaituVR ChaituVR requested a review from wa0x6e July 31, 2024 15:35
wa0x6e
wa0x6e approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e
Copy link
Contributor

wa0x6e commented Jul 31, 2024

Didn't we have a JSON lint to prevent that ?

@ChaituVR
Copy link
Member Author

ChaituVR commented Jul 31, 2024 •
edited
Loading

yea true, #2611 but somehow no action was ran on this PR 🤔

@ChaituVR ChaituVR merged commit 0e96486 into master Jul 31, 2024
1 check passed
@ChaituVR ChaituVR deleted the ChaituVR-patch-3 branch July 31, 2024 15:45
@wa0x6e
Copy link
Contributor

wa0x6e commented Jul 31, 2024

Seems like this action is not run when PR is opened by someone not from the team.

We could either:

  • Allow this action to always be run for PR opened by external contributor
  • Prevent the merge on master to continue when workflows are failing (I prefer this, and I think we're already using this on some repo)

@ChaituVR
Copy link
Member Author

Prevent the merge on master to continue when workflows are failing (I prefer this, and I think we're already using this on some repo)

For this @bonustrack need to change Branch protection rule settings similar to here https://github.com/snapshot-labs/snapshot.js/settings/branch_protection_rules/17997175
and add this action mandatory
Untitled 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e