Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: instrument the cache engine #250

Merged
merged 1 commit into from
Mar 25, 2024
Merged

chore: instrument the cache engine #250

merged 1 commit into from
Mar 25, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Mar 25, 2024 •
edited
Loading

🚧 Changes

Instrument the cache engine

  • Track number of hit/miss per type (votesReports, aiSummary, etc...)

🛠️ Tests

  • Send a curl request to any endpoint using a cache (e.g. curl -X POST localhost:3005/api/votes/[PROPOSAL-ID])
  • Go to http://localhost:3005/metrics
  • You should see new metrics under
# HELP cache_hit_count Number of hit/miss of the cache engine
# TYPE cache_hit_count counter

@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

@wa0x6e wa0x6e requested a review from ChaituVR March 25, 2024 07:51
@wa0x6e wa0x6e marked this pull request as ready for review March 25, 2024 07:51
ChaituVR
ChaituVR approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit 61a39b5 into main Mar 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR