fix: fix handling of corrupted images #205
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧿 Current issues / What's wrong ?
Although rare, image processing fail on some corrupted, or badly generated image, making the while workflow crash with a unhandled error.
💊 Fixes / Solution
Fix #152
Fix PINEAPPLE-7
Some devices such as older samsung galaxy are generating "corrupted" images (see lovell/sharp#1578)
By ignoring corruption error, those image can be processed.
In case user upload a genuine corrupted image, it will just output a corrupted image, and will be the user fault.
🚧 Changes
🛠️ Tests
An example of corrupted image is in test/units/providers/fixtures/corrupted.jpeg
Try uploading to pineapple:
before: it fails with an
VipsJpeg: Invalid SOS parameters for sequential JPEG
errorafter: it should work