Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the built-in RetryOnConflict function #21

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

therealak12
Copy link
Member

@therealak12 therealak12 commented Nov 16, 2023

Instead of printing re-queuing item due to optimistic locking on resource and repeating the whole reconcile loop, retry the update that failed due to an old resource version.

The idea comes from this blog post.

@therealak12 therealak12 added the enhancement New feature or request label Nov 16, 2023
@hoptical hoptical self-requested a review November 18, 2023 12:55
@hoptical hoptical merged commit e8709bf into main Nov 18, 2023
3 checks passed
@hoptical hoptical deleted the retry-on-conflict branch November 19, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants