Patch Auth to support LDAP Authentication #77
Conversation
…hat is done remotely. 2. Modify the corresponding code Handlers.hs, AuthManager.hs, and JsonFile.hs to use this new method 3. Add an experimental Ldap Auth backend.
| @@ -168,7 +168,8 @@ Library | |||
| unordered-containers >= 0.1.4 && < 0.3, | |||
| vector >= 0.7.1 && < 0.11, | |||
| vector-algorithms >= 0.4 && < 0.6, | |||
| xmlhtml >= 0.1 && < 0.3 | |||
| xmlhtml >= 0.1 && < 0.3, | |||
| LDAP >= 0.6.8 && < 0.6.9 | |||
There was a problem hiding this comment.
Hmmm, I'm not crazy about introducing LDAP as a dependency, especially since it binds to a C API.
There was a problem hiding this comment.
Agreed -- is there some way we can make this a third-party downloadable package? The auth mechanism should be extensible, if it isn't we should put some work into that.
There was a problem hiding this comment.
IAuthBackend is not general enough to support remote authentication.
I'm ok if the patch only includes:
AuthManager.hs
Backends/JsonFile.hs
Handlers.hs
This patch will not introduce extra dependency.
Thank,
Ning
On 02/19/2013 01:24 AM, Gregory Collins wrote:
In snap.cabal:
@@ -168,7 +168,8 @@ Library
unordered-containers >= 0.1.4 && < 0.3,
vector >= 0.7.1 && < 0.11,
vector-algorithms >= 0.4 && < 0.6,
- xmlhtml >= 0.1 && < 0.3
- xmlhtml >= 0.1 && < 0.3,
- LDAP >= 0.6.8 && < 0.6.9
Agreed -- is there some way we can make this a third-party
downloadable package? The auth mechanism should be extensible, if it
isn't we should put some work into that.—
Reply to this email directly or view it on GitHub
https://github.com/snapframework/snap/pull/77/files#r3058889.
There was a problem hiding this comment.
+1 to making the necessary changes to snap to allow for a third party LDAP library.
There was a problem hiding this comment.
I hope to get around to investigating this soon. Thank you for the patch.
On Friday, February 22, 2013 at 5:00 AM, Oliver Charles wrote:
In snap.cabal:
@@ -168,7 +168,8 @@ Library > unordered-containers >= 0.1.4 && < 0.3, > vector >= 0.7.1 && < 0.11, > vector-algorithms >= 0.4 && < 0.6, > - xmlhtml >= 0.1 && < 0.3 > + xmlhtml >= 0.1 && < 0.3, > + LDAP >= 0.6.8 && < 0.6.9
+1 to making the necessary changes to snap to allow for a third party LDAP library.—
Reply to this email directly or view it on GitHub (https://github.com/snapframework/snap/pull/77/files#r3113746).
No description provided.