-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peppy #8
Open
vreuter
wants to merge
25
commits into
snakemake-workflows:main
Choose a base branch
from
vreuter:peppy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Peppy #8
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d34726f
initial peppy imports working
vreuter 59eb4d4
more peppy interop
vreuter f92ae7c
set the index; use master config
vreuter 484976b
cleanup
vreuter b3661dc
remove additional print
vreuter ba4debb
more cleanup
vreuter e1af9a1
peppy files
vreuter d5b6d46
minimize changes, shorten names
vreuter 5964ecf
remove unused import
vreuter 6b54e14
get back validate
vreuter 37ded42
need to check files entry
vreuter ca76544
guards and cleanup
vreuter e85a876
clear unused KV in project config
vreuter 6711da2
condense and explain
vreuter 6fde15f
peppy-compatible subannotation / units sheet
vreuter 72ba626
Merge branch 'master' of github.com:snakemake-workflows/dna-seq-gatk-…
vreuter bd8f36b
see about adding units dynamically
vreuter 6e49167
using SnakeProject
vreuter 682bb5d
use Snakemake naming
vreuter 0d2fc1f
use base anns file due to identical content
vreuter e7301f3
add prj cfg that uses the base files
vreuter 1750ab6
use the native encoding
vreuter 6192d29
condense config files
vreuter f728c37
update to reflect peppy updates; https://github.com/snakemake-workflo…
vreuter 0e37cfb
fix name mistake; https://github.com/snakemake-workflows/dna-seq-gatk…
vreuter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
metadata: | ||
sample_table: samples.tsv | ||
subsample_table: units.tsv | ||
|
||
snake_config: "config.yaml" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
sample_name platform fq1 fq2 | ||
A ILLUMINA data/reads/a.chr21.1.fq data/reads/a.chr21.2.fq | ||
B ILLUMINA data/reads/b.chr21.1.fq data/reads/b.chr21.2.fq | ||
B ILLUMINA data/reads/b.chr21.1.fq |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! What about always converting the subsample_table index into string inside peppy (in order to get rid of the line below)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi johannes, it looks like this has been done (the line is now gone).