Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.5.0 #193

Merged
merged 1 commit into from
Feb 18, 2024
Merged

v3.5.0 #193

merged 1 commit into from
Feb 18, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Feb 17, 2024

@taiki-e
Copy link
Collaborator

taiki-e commented Feb 18, 2024

I think it would be safer to raise the minor version since this could potentially cause a subtle change in behavior. (I have in mind the previous regression of async-proces due to a change in implementation on Linux introduced in the patch version.)
Otherwise LGTM.

@notgull notgull changed the title v3.4.1 v3.5.0 Feb 18, 2024
@notgull
Copy link
Member Author

notgull commented Feb 18, 2024

I think it would be safer to raise the minor version since this could potentially cause a subtle change in behavior. (I have in mind the previous regression of async-proces due to a change in implementation on Linux introduced in the patch version.) Otherwise LGTM.

I doubt that any significant infrastructure has been built on polling in Redox, as no one noticed it was using the inefficient polling backend until now. Still, it's probably safer.

Signed-off-by: John Nunley <[email protected]>
@notgull notgull merged commit 4d64fdc into master Feb 18, 2024
24 checks passed
@notgull notgull deleted the notgull/next branch February 18, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants