Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on waker-fn #171

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Remove dependency on waker-fn #171

merged 4 commits into from
Nov 6, 2023

Conversation

asonix
Copy link
Contributor

@asonix asonix commented Nov 5, 2023

Resolves #165

Adds a new concrete type BlockOnWaker that implements Wake

notgull
notgull reviewed Nov 5, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me aside from one minor nitpick.

src/driver.rs Show resolved Hide resolved
notgull
notgull approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit e779304 into smol-rs:master Nov 6, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the waker-fn dependency
2 participants
@asonix @notgull