Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for target resolution #5363

Merged
merged 5 commits into from
Mar 30, 2019
Merged

Fixes for target resolution #5363

merged 5 commits into from
Mar 30, 2019

Conversation

Slayer95
Copy link
Contributor

@Slayer95 Slayer95 commented Mar 27, 2019 •
edited
Loading

  • Storm Drain and Lightningrod now redirect attacks originally targetted against an empty allied slot of the attacker.
  • Imprison and Snatch no longer affect both self and foeSide.

Fixes #5361 and fixes #5362.

Zarel
Zarel reviewed Mar 27, 2019
View reviewed changes
sim/battle.ts Show resolved Hide resolved
Zarel
Zarel reviewed Mar 27, 2019
View reviewed changes
sim/pokemon.ts Outdated Show resolved Hide resolved
@Slayer95 Slayer95 force-pushed the target-resolution branch from 65cae42 to 7642308 Compare March 27, 2019 17:54
@Slayer95
Copy link
Contributor Author

Updated~

Zarel
Zarel reviewed Mar 28, 2019
View reviewed changes
data/mods/gen3/scripts.js Outdated Show resolved Hide resolved
Zarel
Zarel reviewed Mar 28, 2019
View reviewed changes
sim/battle.ts Outdated Show resolved Hide resolved
@Slayer95 Slayer95 force-pushed the target-resolution branch from 7642308 to 6a11d55 Compare March 28, 2019 18:16
@Slayer95
Copy link
Contributor Author

Updated ~

@Zarel
Copy link
Member

Zarel commented Mar 30, 2019

Thanks!

@Zarel Zarel merged commit 694cd47 into smogon:master Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zarel Zarel Zarel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirection should work if the player targeted an empty ally slot Imprison and Snatch targetting is broken
2 participants
@Slayer95 @Zarel