Switch hints to use double quotes everywhere

[scheibo]

Also, have Battle#hint take Side per @urkerab's suggestion.
Followup to #5258, no functionality changes.

[Zarel]

The rule I have in mind is:

foo(bar, baz);
// good

foo(bar,
  baz);
// good

foo(
  bar,
  baz
);
// good

foo(bar,
  baz
);
// bad

foo(
  bar,
  baz);
// bad

[scheibo]

I agree, that seems like a good style. TBH though, I think we should be using an automatic formatter (prettier, clang-format, etc, take your pick) and if we can't configure it with the style we want completely (the string quoting rules spring to mind) we should just accept it because not having to GAF about formatting issues and having an automatically uniform codebase far outweighs trying to manually achieve 'perfection' but having it poorly done (humans are fallible). I go into more details about that in the doc I'm writing reviewing PS with suggestions, but because its came up twice recently I figured I might as well float the idea your way earlier.

[Zarel]

Hm. I've always thought prettier output was uglier than the manual stuff we've been doing. I don't really mind everything being somewhat inconsistent, in exchange for being able to convey information with code structure.

[Zarel]

I think the current tradeoff is good enough; we leave some formatting decisions in the hands of coders (and accept that they might be wrong sometimes), in exchange for having some flexibility in how you want the code to look.

[scheibo]

Hm. I've always thought prettier output was uglier than the manual stuff we've been doing. I don't really mind everything being somewhat inconsistent, in exchange for being able to convey information with code structure.

I haven't used prettier, I'm using a clang-format based solution that we use at work (I suggested prettier because its more popular). Its not perfect (I really dont like that it makes type A = 'foo' | 'bar' | ... into type A = 'foo'|'bar'|... for example), but I've stopped fighting it after having used it for several years (and you can always selectively turn it off for sections where it does something stupid. I might even be able to configure, I havent bothered looking into it).

I really like the style of the new PS (and Preact PS client) code. I think before suggesting a move to an automatic formatter more formally I'll need to try setting one up and seeing concretely what changes it would make. I don't know about prettier, but I think clang-format comes pretty close to what we're doing anyway (minus the "/`/' stuff)