Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFA/Multi: Fix simultaneous timeouts #10311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MathyFurret
Copy link
Contributor

No description provided.

@MathyFurret MathyFurret force-pushed the ffa-simultaneous-timeouts branch from 1d10865 to 79c23a4 Compare July 29, 2024 07:34
@MathyFurret
Copy link
Contributor Author

image
Fixes a bug with 2 players simulateneously timing out -- now they will be both be eliminated and the timer will continue (not sure why it resets to 2 minutes though, is that intended?)

@pyuk-bot
Copy link
Contributor

Players start battles with 60 seconds of grace time that gets added back to their timer in addition to the usual however much time per turn. Normally this grace time only gets added when a player stops their timer by responding to a request, but it gets added whenever the timer is updated, which includes a player being eliminated in FFA.

I see this as a bug, as it mostly just serves to annoyingly give people who AFK-time-out at the start of an FFA battle an extra 60 seconds for no reason if someone else times out first by disconnecting out of impatience. I’ve tried to fix this myself, but I couldn’t figure out how, and when I discussed it with Zarel, he didn’t seem to think there was anything wrong with this behavior, so it didn’t get fixed.

@DaWoblefet
Copy link
Member

I'll say that's a bug - like pyuk said, it doesn't seem to me to make any sense to add 60 seconds of grace to another player losing via timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants