-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replay batch endpoint #28
Open
MCGallaspy
wants to merge
7
commits into
smogon:master
Choose a base branch
from
MCGallaspy:add-replay-batch-endpoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL magic can just take a list, and the right thing will happen. No need to construct a string.
mia-pi-git
reviewed
Oct 28, 2024
mia-pi-git
reviewed
Oct 28, 2024
Co-authored-by: Mia <[email protected]>
Co-authored-by: Mia <[email protected]>
Zarel
reviewed
Nov 12, 2024
Zarel
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a conversation on Discord and some reflection, I think I'm sold on this being worth it. I'll merge in fiveish days if there are no objections.
Co-authored-by: Guangcong Luo <[email protected]>
Zarel
reviewed
Nov 13, 2024
Zarel
reviewed
Nov 13, 2024
Is this okay to merge then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked changes to add batch replay endpoint from #27