Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replay batch endpoint #28

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

MCGallaspy
Copy link

Cherry-picked changes to add batch replay endpoint from #27

SQL magic can just take a list, and the right thing
will happen. No need to construct a string.
src/actions.ts Outdated Show resolved Hide resolved
src/actions.ts Outdated Show resolved Hide resolved
src/actions.ts Outdated Show resolved Hide resolved
Copy link
Member

@Zarel Zarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a conversation on Discord and some reflection, I think I'm sold on this being worth it. I'll merge in fiveish days if there are no objections.

Co-authored-by: Guangcong Luo <[email protected]>
src/replays.ts Outdated Show resolved Hide resolved
src/replays.ts Outdated Show resolved Hide resolved
@singiamtel
Copy link
Contributor

Is this okay to merge then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants