Use only current line in tab-completing commands #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.smogon.com/forums/threads/bug-report.3749269/ At this point, it's a bit more than a bug fix.
Changed stuff that npm run test did not like.
|
LGTM, thanks! |
shrianshChari
pushed a commit
to shrianshChari/pokemon-showdown-client
that referenced
this pull request
Oct 8, 2024
* Use only current line in tab-completing commands https://www.smogon.com/forums/threads/bug-report.3749269/ At this point, it's a bit more than a bug fix. * Update client-chat.js Changed stuff that npm run test did not like. * Restore subcommand behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.smogon.com/forums/threads/bug-report.3749269/
At this point, it's a bit more than a bug fix. It seems intuitive that attempting to perform a tab-complete on one line should search for commands on that line, but it doesn't because it's searching for commands using the entire text box, which was also causing the issue of sending lines into chat.
Besides that, I also reverted the behavior of both commands and usernames being able to be candidates of the same autocomplete, while retaining the ability to autocomplete usernames if placed after the command; I'm not sure how it was helpful to go between commands and usernames.