Support more variable best-of challenges #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrisXV
reviewed
Oct 31, 2023
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown-client
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the checkbox used for team-locked best-of-3 play is limited to VGC formats. This change allows the server's format list to determine which formats have the checkbox by default. This was initially requested by side servers, but also fixes a very minor bug of team-locked bo3 challenges showing up for Gen 4 VGC, where you weren't team-locked (you could move around items in between a best-of-three and change team order). I'm sure we'll eventually have a non-VGC format that wants best-of-n support on main as well.
It also allows the challenger to select any of the supported best-of-n options, rather than exclusively being best-of-3.
I'm not super sure about the policy of inline CSS; it's needed for the number input. I can move it to a proper CSS file if desired.