Give JSON files the Access-Control-Allow-Origin: * header #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't the browser ignore CORS when requesting JSONs? |
|
Unless I misunderstood something in my research, no. When I pull moves.json this is the error I see. When I pull news.json however, it works. Only difference being the header. |
|
Yeah you're right, my bad |
Zarel
changed the title
|
Thanks! |
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown-client
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the .htaccess file to allow moves, abilities, and learnsets json files to be accessed across domain by adding the Access-Control-Allow-Origin: * header.
From the research I did on the .htaccess file, this should solve the issue, but I couldn't see these files in my test environment to confirm that this is a fix.