Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formats not found message not appearing #2170

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

Karthik99999
Copy link
Contributor

@Karthik99999 Karthik99999 commented Oct 25, 2023

well actually "No formats found" whatever. Maybe it shouldn't rely on bufs being empty?

@mia-pi-git
Copy link
Member

mia-pi-git commented Oct 25, 2023

Probably should check when looping over bufs to see if there's any text in the string, instead of just that it exists. Would fix this as is.

js/client-mainmenu.js Outdated Show resolved Hide resolved
js/client-mainmenu.js Outdated Show resolved Hide resolved
@DaWoblefet DaWoblefet merged commit 8358265 into smogon:master Nov 16, 2023
1 check passed
@DaWoblefet
Copy link
Member

Thanks all!

MathyFurret pushed a commit to MathyFurret/pokemon-showdown-client that referenced this pull request Mar 25, 2024
@Karthik99999 Karthik99999 deleted the formatselector branch March 31, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants