Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queued action feature #2167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lorumic
Copy link

@lorumic lorumic commented Oct 22, 2023

I propose this general-purpose action queuing feature. The idea originates from the "battle -> choose name -> battle" flow.

When a non-named user clicks on the "Battle" button in the home, they are asked to choose a name (and log in, if the chosen name is registered). After choosing a name/logging in, they need to click the "Battle" button again to do what they originally wanted to do. Ideally, the action that generated the name choice request should be executed automatically once the user has chosen their name.

So, with this change, a general mechanism for action queuing is added - and currently applied to the "Battle" button in the home. The new behaviour is: after finishing the name choice/login flow, the pending action is executed automatically, with no further clicks needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant