Allow Replace Player to work with Player 3 and Player 4 #2152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Free-For-Alls and Multi-Battles, the "replace player" feature doesn't work if you're Player 3 or Player 4. This is because replace player was only coded for P1 and P2. So, I added P3 and P4 to make the feature work for Players 3 and 4.
Proof-of-concept replay: https://sheeplol.neocities.org/ffareplaceplayer/
I tested this in my own client and local server. One Free-For-All battle and one Singles Random Battle. From my testing, this is the correct implementation and doesn't break anything.
There could be a way to write this in a better way, but this seems to be sufficient at least.