Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaveroom confirm when the room no longer exists #2141

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Fix leaveroom confirm when the room no longer exists #2141

merged 1 commit into from
Sep 16, 2023

Conversation

singiamtel
Copy link
Contributor

When using the setting Confirmation before leaving a room, there's a bug that prevents you from leaving if you have this setting turned on. I haven't found any regression, let me know if you want me to test a specific use case

Example on how to replicate the bug:

  • Toggle the setting Confirmation before leaving a room to true
  • Create groupchat with /mgc
  • Destroy it with /dgc
  • Try to leave

@singiamtel
Copy link
Contributor Author

Also when I try to refresh the site with this setting on I get a browser alert with

This page is asking you to confirm that you want to leave — information you’ve entered may not be saved.

Is this intended?

@mia-pi-git mia-pi-git merged commit 18f1bed into smogon:master Sep 16, 2023
1 check passed
@mia-pi-git
Copy link
Member

Thanks!

MathyFurret pushed a commit to MathyFurret/pokemon-showdown-client that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants