Fixed Negative pp Tooltip Issue #1741
Conversation
|
I don't think this is a good change. I intentionally didn't do this, because in modded formats, moves often have different PP from what you think they have. I think it's more important to know exactly how much PP has been deducted, than to show |
|
Would it be feasible to make this only apply to standard formats (base, gen1-7)? |
|
We'd need some way to detect a format as a standard format, but yes, I would be fine with that. |
|
My main thing is that I don't think anyone would be confused about what -1 PP means, so this seems like a pretty unnecessary improvement in general. |
|
I disagree personally Zarel; I think it looks bad to have -1 PP displayed when you can never actually go below 0 PP in the games. In what mods would it ever make sense to have -1 PP displayed anyway? Like, if a mod changes the number of PP on a move server-side, won't the client know about it on rebuild? |
|
@DaWoblefet we also have to consider mods on side servers that don't get client support, and even some formats on main that don't get that (iirc unless something changed, only some formats on main won't receive this update). Still regardless I'm unsure how I feel about negative PP in tooltips. |
|
On the other hand, this is relevant for Leppa Berry interactions... but yes, I'm worried about mods on side servers. |
On second thought: This is really easy to handle inside Leppa Berry without breaking anything else. |
|
On the note of Leppa Berries, the counter on the Tooltip just disappears, in some cases. Check around 7:00 minutes, in this video. |
Do you have a link to a replay? That'd help a lot for fixing this sort of problem. |
Hey sorry, the replay is not mine, and it isn't uploaded to the PS server. It's just something that I found on a popular YouTube Video. |
Zarel
force-pushed
the
master
branch
2 times, most recently
from
f5d3242 to
c24cbd6
Compare
More details, on this issue:
#1740