Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@smogon/calc] Update @pkmn/dex & package-lock.json #581

Merged
merged 1 commit into from
Oct 7, 2023
Merged

[@smogon/calc] Update @pkmn/dex & package-lock.json #581

merged 1 commit into from
Oct 7, 2023

Conversation

shrianshChari
Copy link
Contributor

Updated @pkmn/dex so that tests work.
Basically test now supports SV DLC 1

shrianshChari
shrianshChari commented Oct 7, 2023
View reviewed changes
calc/package-lock.json
@@ -1,18 +1,18 @@
{
"name": "@smogon/calc",
"version": "0.7.0",
"version": "0.8.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why the version in the package-lock.json changes, I just edited the package.json, then did rm -rf node_modules and npm i and the version modified automatically.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe someone forgot to commit a package-lock change? This happened to me too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was me. I forgot to update package-lock.json when releasing a new version. My bad.

@shrianshChari shrianshChari changed the title Fix npm tests [@smogon/calc] Fix npm tests Oct 7, 2023
@thejetou
Copy link
Collaborator

thejetou commented Oct 7, 2023

I'm confused on why this is fixing npm test for you. v0.7.51 is the version with the DLC update which is the why the CI isn't failing on master.

I'm guessing your node_modules is from before this commit which is why tests were failing on your end.

@shrianshChari
Copy link
Contributor Author

Maybe. I'll try and revert the change on my end and run the tests again.

@shrianshChari
Copy link
Contributor Author

Ok, it seems that my node_modules were out of date and the pre-DLC version of @pkmn/dex was installed.

@thejetou thejetou changed the title [@smogon/calc] Fix npm tests [@smogon/calc] Update @pkmn/dex & package-lock.json Oct 7, 2023
@thejetou thejetou reopened this Oct 7, 2023
@thejetou thejetou merged commit 133a278 into smogon:master Oct 7, 2023
4 checks passed
@thejetou
Copy link
Collaborator

thejetou commented Oct 7, 2023

It still doesn't hurt to merge this. Thanks.

@shrianshChari shrianshChari deleted the update-tests branch October 8, 2023 05:49
ForwardFeed pushed a commit to ForwardFeed/damage-calc that referenced this pull request Oct 28, 2023
@shrianshChari @ForwardFeed
Update @pkmn/dex & package-lock.json (smogon#581)
b44f0ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejetou thejetou thejetou left review comments

@monsanto monsanto monsanto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrianshChari @thejetou @monsanto