This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
Add abstraction for SQL databases #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HoeenCoder bump? |
HoeenCoder
reviewed
Aug 3, 2021
src/commands/moderation.ts
Outdated
| await database.withinTransaction([ | ||
| {statement: 'UPDATE servers SET sticky = $1 WHERE serverid = $2', args: [stickyRoles, this.guild.id]}, | ||
| ]); | ||
| await this.massStickyUpdate(role); // I hope this works... |
There was a problem hiding this comment.
Maybe it would be best to change massStickyUpdate to return a Query instead so we can include it in the above transaction.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us run unit tests with an in-memory database (and generally be less dependent on a particular database or database library).
Prerequisite to #27.