Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding OCSF Finding Info missing types #488

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Adding OCSF Finding Info missing types #488

merged 6 commits into from
Nov 28, 2024

Conversation

andream16
Copy link
Contributor

@andream16 andream16 commented Nov 28, 2024 •
edited
Loading

As per discussion, adding better types to work with to model Finding Info.

Minor:

  • Stop gen legacy code from legacy protos
  • Moving to buf workspaces for local gen
  • Ignoring annoying Mac specific gen files

Needed to finish up #487

@andream16 andream16 self-assigned this Nov 28, 2024
@coveralls
Copy link

coveralls commented Nov 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12073385200

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.769%
Totals Coverage Status
Change from base Build 12034657412: 0.0%
Covered Lines: 3489
Relevant Lines: 8558
💛 - Coveralls

@andream16 andream16 merged commit 1a03523 into main Nov 28, 2024
3 checks passed
@andream16 andream16 deleted the andream16/adding-ocsf-ext branch November 28, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@northdpole northdpole northdpole approved these changes

@ptzianos ptzianos Awaiting requested review from ptzianos

@dlicheva dlicheva Awaiting requested review from dlicheva

Assignees

@andream16 andream16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andream16 @coveralls @northdpole