Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing git-clone target #480

Merged
merged 11 commits into from
Nov 26, 2024
Merged

Implementing git-clone target #480

merged 11 commits into from
Nov 26, 2024

Conversation

andream16
Copy link
Contributor

@andream16 andream16 commented Nov 21, 2024

Basic git-clone target built on top of the SDK.

Will look into packaging it after we have a few components from a sample pipeline in place.


Will eventually deprecate new-components - right now this is the fastest and cleanest thing we can do imo.

.github/workflows/test.yml Show resolved Hide resolved
new-components/targets/git-clone/go.mod Outdated Show resolved Hide resolved
new-components/targets/git-clone/cmd/main.go Outdated Show resolved Hide resolved
new-components/targets/git-clone/Dockerfile Outdated Show resolved Hide resolved
@andream16 andream16 self-assigned this Nov 21, 2024
@andream16 andream16 force-pushed the andream16/git-clone-component branch 3 times, most recently from 53f234b to c0c1f9f Compare November 21, 2024 17:21
@andream16 andream16 marked this pull request as ready for review November 21, 2024 17:22
@ptzianos
Copy link
Contributor

@andream16 this is really good, only some nits here and there. can we also add a go build -ldflags "-X my/package/config.Version=1.0.0" type of flag so that we can hardcode the component version in the binary?

@andream16
Copy link
Contributor Author

@andream16 this is really good, only some nits here and there. can we also add a go build -ldflags "-X my/package/config.Version=1.0.0" type of flag so that we can hardcode the component version in the binary?

@ptzianos perhaps let's do this with packaging and inject this as an env var in the SDK lib?

We already have a customisable sdk version variable but we can also add a way to customise the component version from there

@ptzianos
Copy link
Contributor

@andream16 this is really good, only some nits here and there. can we also add a go build -ldflags "-X my/package/config.Version=1.0.0" type of flag so that we can hardcode the component version in the binary?

@ptzianos perhaps let's do this with packaging and inject this as an env var in the SDK lib?

We already have a customisable sdk version variable but we can also add a way to customise the component version from there

can you please create a ticket for this to revisit it some time this week when we start working on the component stuff

@andream16
Copy link
Contributor Author

@andream16 this is really good, only some nits here and there. can we also add a go build -ldflags "-X my/package/config.Version=1.0.0" type of flag so that we can hardcode the component version in the binary?

@ptzianos perhaps let's do this with packaging and inject this as an env var in the SDK lib?
We already have a customisable sdk version variable but we can also add a way to customise the component version from there

can you please create a ticket for this to revisit it some time this week when we start working on the component stuff

@ptzianos yes, done here https://linear.app/smithy/issue/OCU-273/inject-component-version-as-environment-variable-in-the-sdk

@andream16 andream16 merged commit 0b359ee into main Nov 26, 2024
3 checks passed
@andream16 andream16 deleted the andream16/git-clone-component branch November 26, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants