-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing git-clone target #480
Conversation
new-components/targets/git-clone/testing/integration/git_test.go
Outdated
Show resolved
Hide resolved
53f234b
to
c0c1f9f
Compare
dcb1140
to
f4b7505
Compare
new-components/targets/git-clone/testing/integration/git_test.go
Outdated
Show resolved
Hide resolved
@andream16 this is really good, only some nits here and there. can we also add a |
f4b7505
to
2b28a2d
Compare
2b28a2d
to
dd0ad3f
Compare
@ptzianos perhaps let's do this with packaging and inject this as an env var in the SDK lib? We already have a customisable sdk version variable but we can also add a way to customise the component version from there |
can you please create a ticket for this to revisit it some time this week when we start working on the component stuff |
@ptzianos yes, done here https://linear.app/smithy/issue/OCU-273/inject-component-version-as-environment-variable-in-the-sdk |
dd0ad3f
to
0fdd11e
Compare
Basic git-clone target built on top of the SDK.
Will look into packaging it after we have a few components from a sample pipeline in place.
Will eventually deprecate
new-components
- right now this is the fastest and cleanest thing we can do imo.