Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugifx: PDF consumer file path #479

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Bugifx: PDF consumer file path #479

merged 2 commits into from
Nov 19, 2024

Conversation

dlicheva
Copy link
Contributor

PDF consumer bugfixes

  • remove the filepath from the s3 upload
  • ensure long URLs in the results table are fully rendered

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11918729537

Details

  • 2 of 13 (15.38%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 40.769%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/s3/wrapper.go 0 11 0.0%
Totals Coverage Status
Change from base Build 11916419095: -0.04%
Covered Lines: 3489
Relevant Lines: 8558
💛 - Coveralls

@dlicheva dlicheva merged commit 8243fb1 into main Nov 19, 2024
3 checks passed
@dlicheva dlicheva deleted the bugifx/pdf-consumer-file-path branch November 19, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andream16 andream16 andream16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlicheva @coveralls @andream16