Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug #414 where the jira consumer would not create issues with zer… #415

Merged
merged 3 commits into from
Oct 14, 2024
Merged

fix bug #414 where the jira consumer would not create issues with zer… #415

merged 3 commits into from
Oct 14, 2024

Conversation

northdpole
Copy link
Contributor

@northdpole northdpole commented Oct 11, 2024 •
edited by andream16
Loading

  • Making sure to correctly parse ScanStartTime and FirstFound time;
  • Removing unused imports and code preventing correct builds.

@andream16 andream16 force-pushed the bugfix/zero-time-passed-in-templating-options branch from 93a1f3a to 440cc09 Compare October 11, 2024 14:59
@andream16 andream16 force-pushed the bugfix/zero-time-passed-in-templating-options branch from 6b7a12c to 7a7389a Compare October 12, 2024 15:14
ptzianos
ptzianos reviewed Oct 13, 2024
View reviewed changes
pkg/jira/jira/apiutils_test.go Outdated Show resolved Hide resolved
pkg/templating/template_description_test.go Outdated Show resolved Hide resolved
pkg/templating/template_description.go Show resolved Hide resolved
pkg/templating/template_description.go Outdated Show resolved Hide resolved
pkg/templating/template_description_test.go Outdated Show resolved Hide resolved
@andream16 andream16 force-pushed the bugfix/zero-time-passed-in-templating-options branch from 7a7389a to c95e498 Compare October 14, 2024 08:26
@andream16 andream16 force-pushed the bugfix/zero-time-passed-in-templating-options branch from c95e498 to b3c4fc4 Compare October 14, 2024 13:32
@andream16 andream16 merged commit 904719e into main Oct 14, 2024
3 checks passed
@andream16 andream16 deleted the bugfix/zero-time-passed-in-templating-options branch October 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andream16 andream16 andream16 approved these changes

@dlicheva dlicheva dlicheva approved these changes

@ptzianos ptzianos ptzianos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@northdpole @ptzianos @andream16 @dlicheva