close #307 by removing logic which adds duplicate anchors to local tasks #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptzianos
requested changes
Aug 19, 2024
There was a problem hiding this comment.
ProcessTasks does more than just add the anchor step.
- Why are the other operations done ProcessTassk ok to skip?
- Why wasn't this bug caught by tests?
- And why is this change not tested to prevent future issues like this?
- Why isn't the solution to make the addAnchor* helpers idempotent?
northdpole
force-pushed
the
fix-duplicate-draconctl-anchors-for-local-components
branch
from
9b549ef to
9c501ff
Compare
fixed all of these, also made the add env vars idempotent |
ptzianos
approved these changes
Aug 20, 2024
northdpole
deleted the
fix-duplicate-draconctl-anchors-for-local-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.