Fix Slack Consumer #280
Merged
Fix Slack Consumer #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flowirtz
force-pushed
the
fix-slack-consumer
branch
from
d36d01c to
bebfb0f
Compare
ptzianos
approved these changes
Jul 30, 2024
flowirtz
force-pushed
the
fix-slack-consumer
branch
2 times, most recently
from
1e28892 to
6bdf653
Compare
flowirtz
force-pushed
the
fix-slack-consumer
branch
from
6bdf653 to
e476b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Slack consumer. It previously failed to make requests to the Slack API.
Issue Description
Running the Slack consumer as part of a pipeline, it failed with the below error message:
This is because the default docker image uses
scratchas it's base, which doesn't come with CAs.We are resolving that by instead using an
alpineimage as the base, with addedca-certificates.