Minor fix to prevent failures of database migrations tests #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
northdpole
approved these changes
Apr 29, 2024
ptzianos
force-pushed
the
ptzianos/fix-database-migrations-tests
branch
from
2fdd74b to
3e5a93d
Compare
In the last couple of days the migrations test have failed locally for no apparent reason, since no code related to them has changed, the dependency versions have not changed and neither have the migrations themselves. After a little bit of digging it looks like something in the ubuntu container is causing the 'OutOrStderr' function call in the migrations inspect command to return the stderr instead of stdout which in turn causes the jq check in the migrations bash script to get an empty input instead of the JSON doc which in turn causes it to fail immediately. Changing the 'OutOrStderr' to 'OutOrStdout' ensures that the code will always output to stdout as expected or whatever is the out stream.
ptzianos
force-pushed
the
ptzianos/fix-database-migrations-tests
branch
from
09df28a to
2cebdcf
Compare
|
Raised an issue about the issue of reviewdog reporting errors in replaced lines: reviewdog/reviewdog#1725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #155
In the last couple of days the migrations test have failed locally for no apparent reason, since no code related to them has changed, the dependency versions have not changed and neither have the migrations themselves. After a little bit of digging it looks like something in the ubuntu container is causing the 'OutOrStderr' function call in the migrations inspect command to return the stderr instead of stdout which in turn causes the jq check in the migrations bash script to get an empty input instead of the JSON doc which in turn causes it to fail immediately. Changing the 'OutOrStderr' to 'OutOrStdout' ensures that the code will always output to stdout as expected or whatever is the out stream.