remove positional migrations path from job in favour of the env var

smithy-security · Aug 8, 2024 · 29c6085 · 29c6085
1 parent a26b43c
commit 29c6085
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/cmd/draconctl/main.go b/cmd/draconctl/main.go
@@ -64,7 +64,7 @@ func initializeConfig(cmd *cobra.Command) error {
 
 	// Bind to environment variables
 	// Works great for simple config names, but needs help for names
-	// like --favorite-color which we fix in the bindFlags function
+	// like --favorite-color which we fix in the visitall function
 	v.AutomaticEnv()
 
 	if !slices.Contains(supportedLogFormats, strings.ToLower(loggingFormat)) {

diff --git a/deploy/deduplication-db-migrations/chart/templates/migrations-job.yaml b/deploy/deduplication-db-migrations/chart/templates/migrations-job.yaml
@@ -32,7 +32,6 @@ spec:
         - apply
         - --url
         - "postgresql://{{ .Values.database.auth.username }}:{{ .Values.database.auth.password }}@{{ .Values.database.host }}/{{ .Values.database.auth.database }}?{{ .Values.database.auth.querystringargs}}"
-        - ${DRACONCTL_MIGRATIONS_PATH}
         resources:
           {{- toYaml .Values.resources | nindent 12 }}
       serviceAccountName: {{ include "deduplication_db_migrations.fullname" . }}