DO NOT MERGE: Flex Checksums #3924
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It sets default values for the ChecksumAlgorithm field (although that doesn't actually seem to be reflected in the code at the moment)
Value is not yet added to ConfigBag
Still need to implement tests from SEP
Note: it doesn't actually work because sigv4 is benig added as a dev dep but is required by one of the inlineable interceptors as a runtime dep so that still needs to be fixed.
Update codegen to point to new checksum config
To traverse the model via a knowledge index
Update PutBucketLifecycleConfiguration test it now checks the Crc32 checksum header instead of Md5
It now short circuits if a user has manually set a checksum header and it evaluates the set checksum algorithm as late as possible to avoid that error interfering with user provided checksums
Specifically use the x-amz-checksum- prefix for filtering the checksum headers instead of a fixed list
Update checksum tests to add user-provided checksum tests from SEP
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
…tion` methods. (#3918) This PR lays the groundwork for defining operation-specific `CustomizableOperation` methods. ## Codegen Example If we were to define pre-signable ops this way, code like the following would be emitted for each op that supported presigning. ```rust impl<E, B> CustomizableOperation<crate::operation::put_object::PutObject, E, B> { /// Sends the request and returns the response. #[allow(unused_mut)] pub async fn presigned( mut self, presigning_config: crate::presigning::PresigningConfig, ) -> ::std::result::Result<crate::presigning::PresignedRequest, crate::error::SdkError<E>> where E: std::error::Error + ::std::marker::Send + ::std::marker::Sync + 'static, B: crate::client::customize::internal::CustomizablePresigned<E>, { self.execute(move |sender, conf| sender.presign(conf, presigning_config)).await } } ``` _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
The crc64fast-nvme crate uses some 64 bit intrinsics that do not exist on 32 bit x86 Exclude another test from x86
landonxjames
force-pushed
the
feature/flexible-checksums
branch
from
09aeece
to
9ebc992
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently just making this PR so I can test the canary against the feature branch
Description
Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.