Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate http client implementation(s) #3866

Merged
merged 19 commits into from
Oct 14, 2024
Merged

consolidate http client implementation(s) #3866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
dacc40e
extract hyper client into new crate
aajtodd Oct 4, 2024
00a1d42
feature gate hyper 014 and legacy tls stack
aajtodd Oct 4, 2024
bcf3083
fix tests and remove need for aws-smithy-runtime only API
aajtodd Oct 4, 2024
76db4d9
migrate hyper 1.x support into new crate
aajtodd Oct 4, 2024
4e55481
Merge branch 'hyper1' into http-client
aajtodd Oct 7, 2024
173426e
fixup some CI issues
aajtodd Oct 7, 2024
65344d3
fix more clippy warnings
aajtodd Oct 7, 2024
8a3f315
more fixes
aajtodd Oct 7, 2024
e51ab3f
workaround unable to suppress deprecation warning issue
aajtodd Oct 8, 2024
579f359
fix task registration
aajtodd Oct 8, 2024
0f89d51
update lockfiles
aajtodd Oct 8, 2024
970d22f
leave unstable for now, fix deps, and fix min version of tower
aajtodd Oct 8, 2024
a5d153a
fix cargo.toml
aajtodd Oct 8, 2024
58cc60b
more CI fixes
aajtodd Oct 8, 2024
d0c8c42
fix feature flags and required deps
aajtodd Oct 9, 2024
d9dae04
update exotic target support CI to exclude http client crate
aajtodd Oct 9, 2024
7e5423b
fix ci and try to upgrade cargo-deny
aajtodd Oct 9, 2024
bb1f4dd
add zlib and fix external types
aajtodd Oct 10, 2024
baa9cee
fix feature flag and external types; intent to stabilize
aajtodd Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .cargo-deny-config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
# More documentation for the licenses section can be found here:
# https://embarkstudios.github.io/cargo-deny/checks/licenses/cfg.html
[licenses]
default = "deny"
unlicensed = "deny"
copyleft = "deny"
allow-osi-fsf-free = "neither"
Comment on lines -7 to -10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we keep these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated cargo-deny in the docker image to try and fix the panic happening due to some edge case triggered by aws-smithy-http-client. These are all the default now and an error on latest version. See EmbarkStudios/cargo-deny#611

allow = [
# See https://spdx.org/licenses/ for list of possible licenses
# [possible values: any SPDX 3.11 short identifier (+ optional exception)].
Expand All @@ -19,6 +15,7 @@ allow = [
"MPL-2.0",
"Unicode-DFS-2016",
"Unicode-3.0",
"Zlib"
]
confidence-threshold = 1.0
exceptions = [
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,35 +236,35 @@ jobs:
name: Exotic platform support
runs-on: ubuntu-latest
timeout-minutes: 10
env:
CROSS_CONFIG: Cross.toml
strategy:
fail-fast: false
# We always exclude `aws-smithy-http-server-python`, `aws-smithy-http-server-typescript`, and `aws-smithy-experimental` since they are experimental.
# We exclude `aws-smithy-http-client` due to FIPS related feature flags and aws-lc-fips target support
matrix:
include:
# We always exclude `aws-smithy-http-server-python` and
# `aws-smithy-http-server-typescript` since they are experimental.
- target: i686-unknown-linux-gnu
build_smithy_rs_features: --all-features
build_aws_exclude: ''
build_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental
build_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental --exclude aws-smithy-http-client
test_smithy_rs_features: --all-features
test_aws_exclude: ''
test_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental
test_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental --exclude aws-smithy-http-client
- target: powerpc-unknown-linux-gnu
build_smithy_rs_features: ''
build_aws_exclude: --exclude aws-inlineable
build_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental
build_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental --exclude aws-smithy-http-client
test_smithy_rs_features: ''
test_aws_exclude: --exclude aws-inlineable
test_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript
test_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental --exclude aws-smithy-http-client
- target: powerpc64-unknown-linux-gnu
build_smithy_rs_features: ''
build_aws_exclude: --exclude aws-inlineable
build_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental
build_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental --exclude aws-smithy-http-client
test_smithy_rs_features: ''
test_aws_exclude: --exclude aws-inlineable
test_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental
env:
CROSS_CONFIG: Cross.toml
test_smithy_rs_exclude: --exclude aws-smithy-http-server-python --exclude aws-smithy-http-server-typescript --exclude aws-smithy-experimental --exclude aws-smithy-http-client
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
Loading
Loading