Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-specific search dictionary #2401

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

trishorts
Copy link
Contributor

user dmorgan reported issue during non-specific search of key already existing.

#2400

This PR adds cod the check the dictionary for existence of a key before adding.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.70%. Comparing base (1d402e2) to head (73eb70b).

Files Patch % Lines
...cificEnzymeSearch/NonSpecificEnzymeSearchEngine.cs 42.85% 6 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2401      +/-   ##
==========================================
+ Coverage   93.65%   93.70%   +0.04%     
==========================================
  Files         140      140              
  Lines       21896    21908      +12     
  Branches     3005     3007       +2     
==========================================
+ Hits        20506    20528      +22     
+ Misses        934      925       -9     
+ Partials      456      455       -1     
Files Coverage Δ
...cificEnzymeSearch/NonSpecificEnzymeSearchEngine.cs 89.54% <42.85%> (+2.07%) ⬆️

@nbollis nbollis linked an issue Aug 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash running a non-specific search.
2 participants